-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'upward style for slider controls #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 4 files in this pull request and found no issues.
It looks like GTK is the only backend which tells the native control about the direction. Do Cocoa/Win32 have any corresponding functions? NSSlider, for example, seems to "fill up" from the bottom (but not if there are ticks?), so a On win32, I see something called (BTW, is there an easy way to build and test a package like racket/gui which has lots of dependencies and dependents in the stdlib? I've looked around a little and haven't found anything yet.) |
I couldn't find a way to get downward sliders to render right on Mac OS when the range is >= 64, so I added a note to the documentation that rendering could be misleading. @kengruven — Thanks for the pointer to For info on trying out changes to a package like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 4 files in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 4 files in this pull request and found no issues.
Relevant to #314.
As far as I can tell, a vertical slider in
racket/gui
is top-to-bottom on all platforms. I don't know or remember why, but I agree that a bottom-to-top slider seems more useful, and probably non-racket/gui
programs use bottom-to-top sliders everywhere. The top-to-bottom rendering is also inherent in the macOS control, at least when the range is >= 64.To add bottom-to-top support without breaking any old programs — just in case — this commit adds an
'upward
style option alongside'horizontal
and'vertical
.